Use container info as passed in from ULIMS - #89
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 98.88% 98.89%
=======================================
Files 20 20
Lines 984 991 +7
=======================================
+ Hits 973 980 +7
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jacob-williamson
approved these changes
Aug 18, 2026
jacob-williamson
left a comment
jacob-williamson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, haven't yet reviewed the atlas side but tried the UI which works well.
| # Need to get sample info for test samples (air, empty capillary etc) | ||
| sample=Sample(name="fq_1_1", id="", data={}), | ||
| sample=Sample( | ||
| name="fq_1_1", |
Collaborator
There was a problem hiding this comment.
Nit: Could change this to something more sensible now that we don't use it to work out the positon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/atlas#115
To test: